Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Development fl server frontend #71

Merged
merged 50 commits into from
Sep 12, 2024
Merged

Development fl server frontend #71

merged 50 commits into from
Sep 12, 2024

Conversation

SalmaElsoly
Copy link
Contributor

@SalmaElsoly SalmaElsoly commented Aug 11, 2024 •
edited by rawdaGastan
Loading

Description of the changes

  • Created login page
  • Created create flist page
  • Created follow up on flist creation page
  • Created home page
  • Created user list page
  • Created flist preview page

Checklist

  • Good UI Provided by @ehab-hassan
  • Used vue 3 in frontend implementation

@SalmaElsoly SalmaElsoly marked this pull request as draft August 11, 2024 14:14
@Nabil-Salah Nabil-Salah marked this pull request as ready for review August 12, 2024 07:27
maayarosama
maayarosama previously requested changes Aug 14, 2024
View reviewed changes
frontend/src/components/CreateFlist.vue Outdated Show resolved Hide resolved
frontend/src/components/CreateFlist.vue Outdated Show resolved Hide resolved
frontend/src/components/FollowUp.vue Outdated Show resolved Hide resolved
frontend/src/components/FollowUp.vue Outdated Show resolved Hide resolved
frontend/src/components/Home.vue Outdated Show resolved Hide resolved
frontend/src/components/Login.vue Outdated Show resolved Hide resolved
frontend/src/components/Login.vue Outdated Show resolved Hide resolved
frontend/src/components/UserFlist.vue Show resolved Hide resolved
@Nabil-Salah Nabil-Salah self-assigned this Aug 15, 2024
zaelgohary
zaelgohary reviewed Aug 26, 2024
View reviewed changes
frontend/README.md Outdated Show resolved Hide resolved
zaelgohary
zaelgohary requested changes Aug 26, 2024
View reviewed changes
frontend/src/components/PreviewFlist.vue Outdated Show resolved Hide resolved
frontend/src/components/Navbar.vue Outdated Show resolved Hide resolved
frontend/src/components/UserFlist.vue Outdated Show resolved Hide resolved
frontend/src/components/UserFlist.vue Outdated Show resolved Hide resolved
frontend/index.html Outdated Show resolved Hide resolved
frontend/src/components/CreateFlist.vue Outdated Show resolved Hide resolved
frontend/src/components/CreateFlist.vue Outdated Show resolved Hide resolved
frontend/src/components/FollowUp.vue Outdated Show resolved Hide resolved
frontend/src/components/Home.vue Outdated Show resolved Hide resolved
frontend/src/components/Login.vue Outdated Show resolved Hide resolved
@SalmaElsoly SalmaElsoly requested a review from zaelgohary August 26, 2024 11:51
zaelgohary
zaelgohary reviewed Aug 27, 2024
View reviewed changes
frontend/public/global.css Outdated Show resolved Hide resolved
frontend/README.md Outdated Show resolved Hide resolved
frontend/README.md Outdated Show resolved Hide resolved
frontend/README.md Outdated Show resolved Hide resolved
frontend/README.md Show resolved Hide resolved
frontend/src/components/FollowUp.vue Outdated Show resolved Hide resolved
frontend/src/components/FollowUp.vue Outdated Show resolved Hide resolved
frontend/src/components/FollowUp.vue Outdated Show resolved Hide resolved
frontend/src/components/FollowUp.vue Outdated Show resolved Hide resolved
frontend/src/components/Home.vue Show resolved Hide resolved
@zaelgohary
Copy link

image

The route should be small letters.

@SalmaElsoly SalmaElsoly requested a review from zaelgohary August 29, 2024 09:16
zaelgohary
zaelgohary reviewed Aug 29, 2024
View reviewed changes
frontend/README.md Outdated Show resolved Hide resolved
@Nabil-Salah Nabil-Salah requested a review from zaelgohary August 29, 2024 10:51
zaelgohary
zaelgohary approved these changes Aug 29, 2024
View reviewed changes
Copy link

@zaelgohary zaelgohary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! @SalmaElsoly @Nabil-Salah

@rawdaGastan rawdaGastan changed the base branch from development_fl_server to master September 11, 2024 10:32
@Eslam-Nawara Eslam-Nawara changed the base branch from master to development_fl_server September 11, 2024 10:33
@rawdaGastan rawdaGastan changed the base branch from development_fl_server to master September 11, 2024 11:05
@rawdaGastan rawdaGastan changed the base branch from master to development_preview_flist September 11, 2024 13:53
@rawdaGastan rawdaGastan changed the base branch from development_preview_flist to master September 11, 2024 13:55
@rawdaGastan rawdaGastan force-pushed the development_fl_server_frontend branch from 405bb55 to c51f4d6 Compare September 12, 2024 11:02
SalmaElsoly and others added 22 commits September 12, 2024 14:10
@SalmaElsoly @rawdaGastan
fix: tables to contain size + add menu in navbar
b87464a 
Co-authored-by: [email protected] <[email protected]>
@Nabil-Salah @rawdaGastan
fix: spacing in tables
0149999 
Signed-off-by: nabil salah <[email protected]>
@Nabil-Salah @rawdaGastan
fix: compacting home table
cb6d54a 
Signed-off-by: nabil salah <[email protected]>
@SalmaElsoly @rawdaGastan
fix: footer size to have fixed size across all pages
65a4822
@Nabil-Salah @rawdaGastan
fix: tables alignments and font weight
2b0690c 
Signed-off-by: nabil salah <[email protected]>
@Nabil-Salah @SalmaElsoly @rawdaGastan
feat: preview flist page
eaceb42 
Co-authored-by: Salma Elsoly <[email protected]>
@SalmaElsoly @Nabil-Salah @rawdaGastan
feat: add more fields in preview page
dc14b9c 
Co-authored-by: [email protected] <[email protected]>
@SalmaElsoly @Nabil-Salah @rawdaGastan
feat: add preview flist logic
e940445 
Co-authored-by: [email protected] <[email protected]>
@SalmaElsoly @Nabil-Salah @rawdaGastan
docs: add installation
d35590d 
Co-authored-by: [email protected] <[email protected]>
@Nabil-Salah @rawdaGastan
fix: api of preview page link
85c5df9 
Signed-off-by: nabil salah <[email protected]>
@Nabil-Salah @rawdaGastan
refactor: remove flist name in preview page from the header, remove c…
5132da5 
…ommented codes

Signed-off-by: nabil salah <[email protected]>
@SalmaElsoly @rawdaGastan
refactor: remove unnecessary logs + create global style file + combin…
90acab8 
…e related interfaces in one file

Co-authored-by: [email protected] <[email protected]>
@SalmaElsoly @rawdaGastan
docs: update readme
734a7f9
@SalmaElsoly @rawdaGastan
refactor: remove global css to style css + update readme + add toolti…
a551a77 
…ps and alerts

Co-authored-by: [email protected] <[email protected]>
@SalmaElsoly @rawdaGastan
ci: add docker file
b7029c8
@Nabil-Salah @SalmaElsoly @rawdaGastan
reafctor: delagete following uping page for flist to be with create f…
0fec036 
…list page

Co-authored-by: Salma Elsoly <[email protected]>
@SalmaElsoly @rawdaGastan
refactor: lazy loading preview flist + fix routers + move navbar and …
f2f9c29 
…footer to app.vue

Co-authored-by: [email protected] <[email protected]>
@SalmaElsoly @rawdaGastan
refactor: add more tooltips + remove unnessecary logs
e75ecb5 
Co-authored-by: [email protected] <[email protected]>
@SalmaElsoly @rawdaGastan
fix: login page height + forms button on the right side
06dfc3f
@Nabil-Salah @rawdaGastan
fix: route unauth redirecting
e733b5c
@Nabil-Salah @rawdaGastan
docs: typo in readme
b2dda1e
@SalmaElsoly @rawdaGastan
refactor: remove unnessecary logs
13608d4
@rawdaGastan rawdaGastan force-pushed the development_fl_server_frontend branch from c51f4d6 to 13608d4 Compare September 12, 2024 11:10
@rawdaGastan rawdaGastan merged commit 725f1ed into master Sep 12, 2024
2 checks passed
@rawdaGastan rawdaGastan deleted the development_fl_server_frontend branch September 12, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nabil-Salah Nabil-Salah Nabil-Salah left review comments

@zaelgohary zaelgohary zaelgohary approved these changes

@maayarosama maayarosama Awaiting requested review from maayarosama

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SalmaElsoly @zaelgohary @maayarosama @Nabil-Salah @rawdaGastan